talons

Fork of Claws Mail https://www.claws-mail
Log | Files | Refs | README | LICENSE

commit a4df409dd4e6da3bb71c43b3fe912681c6bfe147
parent c8d136eb0ec1c6450b177b0f8c3c253e2b5cb139
Author: wwp <subscript@free.fr>
Date:   Sat,  1 Mar 2025 14:44:09 +0100

Fix CID 1491244, remove (never used anyway) wrong return value causing a use after free.

Diffstat:
Msrc/gtk/gtkaspell.c | 6++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/gtk/gtkaspell.c b/src/gtk/gtkaspell.c @@ -111,7 +111,7 @@ static void button_press_intercept_cb(GtkTextView *gtktext, /* Checker creation */ static GtkAspeller* gtkaspeller_new (Dictionary *dict); static GtkAspeller* gtkaspeller_real_new (Dictionary *dict); -static GtkAspeller* gtkaspeller_delete (GtkAspeller *gtkaspeller); +static void gtkaspeller_delete (GtkAspeller *gtkaspeller); static GtkAspeller* gtkaspeller_real_delete (GtkAspeller *gtkaspeller); /* Checker configuration */ @@ -715,7 +715,7 @@ static GtkAspeller *gtkaspeller_real_new(Dictionary *dict) return gtkaspeller; } -static GtkAspeller *gtkaspeller_delete(GtkAspeller *gtkaspeller) +static void gtkaspeller_delete(GtkAspeller *gtkaspeller) { cm_return_val_if_fail(gtkaspellcheckers, NULL); @@ -730,8 +730,6 @@ static GtkAspeller *gtkaspeller_delete(GtkAspeller *gtkaspeller) debug_print("Aspell: number of existing checkers %d\n", g_slist_length(gtkaspellcheckers->checkers)); - - return gtkaspeller; } static GtkAspeller *gtkaspeller_real_delete(GtkAspeller *gtkaspeller)