talons

commit 20fd6d35ecda5a32b8bf90d39840d6606281f57b
parent 3eaaa6109cebff3a6b04fdc016ef12f16e0bd6ca
Author: Oliver Lowe <o@olowe.co>
Date:   Sat, 16 Aug 2025 15:29:17 +1000

Re-order accounts by buttons only

Diffstat:
M
src/account.c
 | 
56
--------------------------------------------------------
M
src/summaryview.c
 | 
6
------

2 files changed, 0 insertions(+), 62 deletions(-)
diff --git a/src/account.c b/src/account.c
@@ -163,20 +163,6 @@ static void account_double_clicked		(GtkTreeView		*list_view,
 						 GtkTreeViewColumn	*column,
 						 gpointer		 data);
 
-static void drag_begin				(GtkTreeView *list_view,
-						 GdkDragContext *context,
-						 gpointer data);
-
-static void drag_end				(GtkTreeView *list_view,
-						 GdkDragContext *context,
-						 gpointer data);
-
-static void account_row_changed_while_drag_drop	(GtkTreeModel *model,
-						 GtkTreePath  *path,
-						 GtkTreeIter  *iter,
-						 gpointer      arg3,
-						 GtkTreeView  *list_view);
-
 static void account_flush_state(void)
 {
 	account_set_menu();
@@ -1562,14 +1548,6 @@ static GtkWidget *account_list_view_create(void)
 	                 G_CALLBACK(account_double_clicked),
 			 list_view);
 
-	g_signal_connect(G_OBJECT(list_view), "drag_begin",
-			 G_CALLBACK(drag_begin),
-			 list_view);
-
-	g_signal_connect(G_OBJECT(list_view), "drag_end",
-			 G_CALLBACK(drag_end),
-			 list_view);
-
 	gtk_tree_view_set_reorderable(list_view, TRUE);
 	return GTK_WIDGET(list_view);
 }
@@ -1799,40 +1777,6 @@ static void account_double_clicked(GtkTreeView		*list_view,
 	account_edit_prefs(NULL, NULL);
 }
 
-static void drag_begin(GtkTreeView *list_view,
-		      GdkDragContext *context,
-		      gpointer data)
-{
-	/* XXX unfortunately a completed drag & drop does not emit
-	 * a "rows_reordered" signal, but a "row_changed" signal.
-	 * So during drag and drop, listen to "row_changed", and
-	 * update the account list accordingly */
-
-	GtkTreeModel *model = gtk_tree_view_get_model(list_view);
-	g_signal_connect(G_OBJECT(model), "row_changed",
-			 G_CALLBACK(account_row_changed_while_drag_drop),
-			 list_view);
-}
-
-static void drag_end(GtkTreeView *list_view,
-		    GdkDragContext *context,
-		    gpointer data)
-{
-	GtkTreeModel *model = gtk_tree_view_get_model(list_view);
-	g_signal_handlers_disconnect_by_func(G_OBJECT(model),
-					     G_CALLBACK(account_row_changed_while_drag_drop),
-					     list_view);
-}
-
-static void account_row_changed_while_drag_drop(GtkTreeModel *model,
-				   GtkTreePath  *path,
-				   GtkTreeIter  *iter,
-				   gpointer      arg3,
-				   GtkTreeView  *list_view)
-{
-	account_list_set();
-}
-
 gchar *account_get_signature_str(PrefsAccount *account)
 {
 	gchar *sig_body = NULL;
diff --git a/src/summaryview.c b/src/summaryview.c
@@ -416,7 +416,6 @@ static const gchar *const col_label[N_SUMMARY_COLS] = {
 	N_("#"),       /* S_COL_NUMBER  */
 	N_("Score"),   /* S_COL_SCORE   */
 	"",            /* S_COL_LOCKED  */
-	N_("Tags"),    /* S_COL_TAGS    */
 };
 
 void summary_freeze(SummaryView *summaryview)
@@ -5538,11 +5537,6 @@ void summary_collapse_threads(SummaryView *summaryview)
 	gtk_cmctree_node_moveto(ctree, summaryview->selected, 0, 0.5, 0);
 }
 
-static void account_rules_radio_button_toggled_cb(GtkToggleButton *btn, gpointer data)
-{
-	prefs_common.apply_per_account_filtering_rules = GPOINTER_TO_INT(data);
-}
-
 void summaryview_destroy(SummaryView *summaryview)
 {
 	if(summaryview->simplify_subject_preg) {