commit 1a719c663fd2c7ac5cf5e605e16d7c9ed576bca7
parent 8e9c5482d2d1b2ce5625746f13bf1a836340fbca
Author: Oliver Lowe <o@olowe.co>
Date: Wed, 20 Aug 2025 10:34:08 +1000
never show cursor in text view
why is this configurable...?
Diffstat:
7 files changed, 13 insertions(+), 29 deletions(-)
diff --git a/src/headerview.c b/src/headerview.c
@@ -124,7 +124,10 @@ HeaderView *headerview_create(void)
void headerview_init(HeaderView *headerview)
{
headerview_clear(headerview);
- headerview_set_visibility(headerview, prefs_common.display_header_pane);
+ if (prefs_common.display_header_pane)
+ gtk_widget_show(headerview->hbox);
+ else
+ gtk_widget_hide(headerview->hbox);
}
void headerview_show(HeaderView *headerview, MsgInfo *msginfo)
@@ -286,16 +289,3 @@ void headerview_clear(HeaderView *headerview)
gtk_widget_queue_resize(headerview->hbox);
}
}
-
-void headerview_set_visibility(HeaderView *headerview, gboolean visibility)
-{
- if (visibility)
- gtk_widget_show(headerview->hbox);
- else
- gtk_widget_hide(headerview->hbox);
-}
-
-void headerview_destroy(HeaderView *headerview)
-{
- g_free(headerview);
-}
diff --git a/src/headerview.h b/src/headerview.h
@@ -45,8 +45,6 @@ void headerview_init (HeaderView *headerview);
void headerview_show (HeaderView *headerview,
MsgInfo *msginfo);
void headerview_clear (HeaderView *headerview);
-void headerview_set_visibility (HeaderView *headerview,
- gboolean visibility);
void headerview_destroy (HeaderView *headerview);
void headerview_set_font (HeaderView *headerview);
#endif /* __HEADERVIEW_H__ */
diff --git a/src/mainwindow.c b/src/mainwindow.c
@@ -1721,8 +1721,11 @@ static gboolean reflect_prefs_timeout_cb(gpointer data)
hooks_invoke(THEME_CHANGED_HOOKLIST, NULL);
}
- headerview_set_visibility(mainwin->messageview->headerview,
- prefs_common.display_header_pane);
+
+ if (prefs_common.display_header_pane)
+ gtk_widget_show(mainwin->messageview->headerview->hbox);
+ else
+ gtk_widget_hide(mainwin->messageview->headerview->hbox);
textview_reflect_prefs(mainwin->messageview->mimeview->textview);
folderview_reflect_prefs();
summary_reflect_prefs();
@@ -3077,11 +3080,10 @@ static void main_window_set_widgets(MainWindow *mainwin, LayoutType layout_mode)
prefs_common.mainwin_width,
prefs_common.mainwin_height);
}
- /* remove headerview if not in prefs */
- headerview_set_visibility(mainwin->messageview->headerview,
- prefs_common.display_header_pane);
+ if (!prefs_common.display_header_name)
+ gtk_widget_hide(mainwin->messageview->headerview->hbox);
- if (messageview_is_visible(mainwin->messageview))
+ if (mainwin->messageview->visible)
gtk_image_set_from_icon_name(GTK_IMAGE(mainwin->summaryview->toggle_arrow),
"pan-down-symbolic", GTK_ICON_SIZE_MENU);
else
diff --git a/src/mh.c b/src/mh.c
@@ -1189,7 +1189,7 @@ static void mh_scan_tree_recursive(FolderItem *item)
}
mh_scan_tree_recursive(new_item);
- } else if (to_number(dir_name) > 0) n_msg++;
+ }
g_free(entry);
g_free(utf8entry);
diff --git a/src/prefs_common.c b/src/prefs_common.c
@@ -898,9 +898,6 @@ static PrefParam param[] = {
{"folderview_vscrollbar_policy", "0",
&prefs_common.folderview_vscrollbar_policy, P_ENUM,
NULL, NULL, NULL},
- {"textview_cursor_visible", "FALSE",
- &prefs_common.textview_cursor_visible, P_BOOL,
- NULL, NULL, NULL},
{"hover_timeout", "500", &prefs_common.hover_timeout, P_INT,
NULL, NULL, NULL},
diff --git a/src/prefs_common.h b/src/prefs_common.h
@@ -354,7 +354,6 @@ struct _PrefsCommon
gint line_space;
gboolean render_html;
gboolean promote_html_part;
- gboolean textview_cursor_visible;
gboolean enable_smooth_scroll;
gint scroll_step;
gboolean scroll_halfpage;
diff --git a/src/textview.c b/src/textview.c
@@ -555,8 +555,6 @@ void textview_reflect_prefs(TextView *textview)
{
textview_set_font(textview, NULL);
textview_update_message_colors(textview);
- gtk_text_view_set_cursor_visible(GTK_TEXT_VIEW(textview->text),
- prefs_common.textview_cursor_visible);
}
void textview_show_part(TextView *textview, MimeInfo *mimeinfo, FILE *fp)
