talons

commit 0314464dd5c5e4e49f7fb5835e0316726267506e
parent 55dfdd72bff9b26cc9ac6fd5ab5a710bd704e020
Author: Paul <paul@claws-mail.org>
Date:   Sun, 15 Nov 2015 13:45:43 +0000

fix bug 3559, 'Opening preferences window causes out of bounds read'

patch by Hanno Boeck

Diffstat:
M
src/gtk/prefswindow.c
 | 
2
+-

1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gtk/prefswindow.c b/src/gtk/prefswindow.c
@@ -320,7 +320,7 @@ static void prefswindow_build_tree(GtkWidget *tree_view, GSList *prefs_pages,
 			gtk_tree_model_foreach(GTK_TREE_MODEL(store), 
 					       (GtkTreeModelForeachFunc) find_node_by_name,
 					       &find_name);
-			if (find_name.found && page->path[i] != page->path[i-1]) {
+			if (i > 0 && find_name.found && page->path[i] != page->path[i-1]) {
 				node = find_name.node;
 				gtk_tree_model_get(GTK_TREE_MODEL(store), &node,
 						   PREFS_PAGE_DATA, &prefs_node,