issues

Github, Jira, Gitlab issues from Plan 9's acme
Log | Files | Refs | README | LICENSE

commit e4d83a7f98a82848e39885880ed4cb0d741058fe
parent e80961fe8ae238bac3883d9cffc9fe1941ae7bb6
Author: Oliver Lowe <oliver.lowe@audinate.com>
Date:   Wed,  2 Jul 2025 15:06:57 +1000

jira: return no error on success lol

Diffstat:
Mcmd/Jira/create.go | 2+-
Mjira/http.go | 14+++++---------
2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/cmd/Jira/create.go b/cmd/Jira/create.go @@ -37,7 +37,7 @@ func (w *awin) put() error { if err != nil { return fmt.Errorf("read issue: %w", err) } - if _, err := f.Client.CreateIssue(*issue); err != nil { + if err := f.Client.CreateIssue(*issue); err != nil { return fmt.Errorf("create issue: %w", err) } } diff --git a/jira/http.go b/jira/http.go @@ -128,26 +128,22 @@ func (c *Client) Comment(ikey, id string) (*Comment, error) { return &com, err } -func (c *Client) CreateIssue(issue Issue) (*Issue, error) { +func (c *Client) CreateIssue(issue Issue) error { u := *c.APIRoot u.Path = path.Join(u.Path, "issue") resp, err := c.postJSON(u.String(), &issue) if err != nil { - return nil, fmt.Errorf("post json: %w", err) + return fmt.Errorf("post json: %w", err) } defer resp.Body.Close() if resp.StatusCode >= http.StatusBadRequest { var eresp errorResponse if err := json.NewDecoder(resp.Body).Decode(&eresp); err != nil { - return nil, fmt.Errorf("status %s: decode error response: %w", resp.Status, err) + return fmt.Errorf("status %s: decode error response: %w", resp.Status, err) } - return nil, eresp - } - var created Issue - if err := json.NewDecoder(resp.Body).Decode(&created); err != nil { - return nil, fmt.Errorf("decode created issue: %w", err) + return eresp } - return &created, nil + return nil } func (c *Client) PostComment(issueKey string, body io.Reader) error {