issues

commit cd1c898f02fb2249fbcd5211db3c9fde897845c5
parent d6f7698eb10147db56dfaaf77481c6e6f9170725
Author: Dmitri Shuralyov <dmitri@shuralyov.com>
Date:   Sun, 29 Sep 2024 20:49:17 -0400

issue, issuedb: various fixes (#10)

As reported by vet and staticcheck.
Diffstat:
M
issue/issue.go
 | 
4
+++-
M
issuedb/main.go
 | 
8
++++----
M
issuedb/todo.go
 | 
2
+-

3 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/issue/issue.go b/issue/issue.go
@@ -729,7 +729,9 @@ func loadAuth() {
 			"password directly is that you can limit its use and revoke it at any time.\n\n")
 	}
 	fi, err := os.Stat(filename)
-	if fi.Mode()&0077 != 0 {
+	if err != nil {
+		log.Fatal(err)
+	} else if fi.Mode()&0077 != 0 {
 		log.Fatalf("reading token: %s mode is %#o, want %#o", shortFilename, fi.Mode()&0777, fi.Mode()&0700)
 	}
 	authToken = strings.TrimSpace(string(data))
diff --git a/issuedb/main.go b/issuedb/main.go
@@ -262,7 +262,7 @@ func downloadByDate(proj *ProjectSync, api string, since *string, sinceName stri
 				return fmt.Errorf("parsing message: %v", err)
 			}
 			if meta.Updated == "" {
-				return fmt.Errorf("parsing message: no updated_at: %s\n", string(m))
+				return fmt.Errorf("parsing message: no updated_at: %s", string(m))
 			}
 			last = meta.Updated
 
@@ -271,14 +271,14 @@ func downloadByDate(proj *ProjectSync, api string, since *string, sinceName stri
 			raw.Project = proj.Name
 			switch api {
 			default:
-				log.Fatal("downloadByDate: unknown API: %v", api)
+				log.Fatalf("downloadByDate: unknown API: %v", api)
 			case "/issues":
 				raw.Issue = meta.Number
 			case "/issues/comments":
 				i := strings.LastIndex(meta.IssueURL, "/")
 				n, err := strconv.ParseInt(meta.IssueURL[i+1:], 10, 64)
 				if err != nil {
-					log.Fatal("cannot find issue number in /issues/comments API: %v", urlStr)
+					log.Fatalf("cannot find issue number in /issues/comments API: %v", urlStr)
 				}
 				raw.Issue = n
 			}
@@ -600,7 +600,7 @@ func retime() {
 	for {
 		var all []RawJSON
 		if err := storage.Select(db, &all, "where URL > ? and Time = ? order by URL asc limit 100", last, ""); err != nil {
-			log.Fatal("sql: %v", err)
+			log.Fatalf("sql: %v", err)
 		}
 		if len(all) == 0 {
 			break
diff --git a/issuedb/todo.go b/issuedb/todo.go
@@ -257,7 +257,7 @@ func process(proj *ProjectSync, since time.Time, do func(proj *ProjectSync, issu
 	for rows.Next() {
 		var raw RawJSON
 		if err := rows.Scan(&raw.URL, &raw.Project, &raw.Issue, &raw.Type, &raw.JSON, &raw.Time); err != nil {
-			log.Fatal("sql scan RawJSON: %v", err)
+			log.Fatalf("sql scan RawJSON: %v", err)
 		}
 		if raw.Issue != lastIssue {
 			if len(items) > 0 {