issues

commit c3f6de414aa7ec58d1c876f8545c060940bbf65d
parent aadd74393741cfe5e41f181f3a43dae846d7f062
Author: Oliver Lowe <o@olowe.co>
Date:   Mon, 30 Jun 2025 15:17:22 +1000

issue: limit authToken string to where it's needed

Nothing else reads this global var

Diffstat:
M
go.sum
 | 
2
--
M
issue/issue.go
 | 
5
+----

2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/go.sum b/go.sum
@@ -3,8 +3,6 @@
 dmitri.shuralyov.com/gpu/mtl v0.0.0-20201218220906-28db891af037/go.mod h1:H6x//7gZCb22OMCxBHrMx7a5I7Hp++hsVxbQ4BYO7hU=
 github.com/BurntSushi/xgb v0.0.0-20160522181843-27f122750802/go.mod h1:IVnqGOEym/WlBOVXweHU+Q+/VP0lqqI8lqeDx9IjBqo=
 github.com/go-gl/glfw/v3.3/glfw v0.0.0-20200222043503-6f7a984d4dc4/go.mod h1:tQ2UAYgL5IevRw8kRxooKSPJfGvJ9fJQFa0TUsXzTg8=
-github.com/golang/protobuf v1.2.0 h1:P3YflyNX/ehuJFLhxviNdFxQPkGK5cDcApsge1SqnvM=
-github.com/golang/protobuf v1.2.0/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U=
 github.com/google/go-cmp v0.5.2/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
 github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
 github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
diff --git a/issue/issue.go b/issue/issue.go
@@ -470,9 +470,6 @@ func wrap(t string, prefix string) string {
 
 var client *github.Client
 
-// GitHub personal access token, from https://github.com/settings/applications.
-var authToken string
-
 func loadAuth(name string) error {
 	data, err := os.ReadFile(name)
 	if err != nil {
@@ -482,7 +479,7 @@ func loadAuth(name string) error {
 	if fi.Mode()&0077 != 0 {
 		return fmt.Errorf("stat token: mode is %#o, want %#o", fi.Mode()&0777, fi.Mode()&0700)
 	}
-	authToken = strings.TrimSpace(string(data))
+	authToken := strings.TrimSpace(string(data))
 	t := &oauth2.Transport{
 		Source: &tokenSource{AccessToken: authToken},
 	}